Sunday, January 02, 2011

KWalletEditor no longer depends on Qt3Support

I've just commited to trunk (KDE 4.7) the last of the changes I started doing a few days ago to make KWalletEditor not depend on Qt3Support/KDE3Support. Basically that meant rewriting all the Q3IconView and K3ListView as KListWidget and QTreeWidget with the associated Drag&Drop changes. I've been testing the code for the usual problems of this type of porting while doing the code changes but something might have escaped me so I'll be more than happy if you give it some usage and report to me any problem you might find.

10 comments:

Anonymous said...

How big part of KDE4 still depends on Qt3/KDE3Support and what does that mean in practise? Purely out of curiosity :p

chani said...

awesome :)

I've been wishing I had time to just write a new UI for a while - one that doesn't require quite so many clicks, and stays in one window.

are you planning to make any UI changes, or just doing internal cleanup?

Anonymous said...

What about 207901?

It seems like it doesn't get any deserved attention.

Albert Astals Cid said...

@Anon: There's very few places that still depend on Qt3/KDE3Support, i really don't know them all so i can't give you a list. It means that it's using code that is in practice unsupported and more important that does not exist in platforms were Qt3 did not exist (e.g. Maemo or some of the newer Mac platforms). Also the more libraries you pull the somewhat slower your binary is to start, but that should not be noticeable in real life scenarios

Albert Astals Cid said...

@Chani: I do not plan to do any further work besides fixing any bug i may have introduced

Albert Astals Cid said...

To whoever posted "What about 207901?", i have no idea what happened with your comment but as said to Chani all my aim here was to remove Qt3/KDE3Support and do not plan to do any further development.

Kai Uwe said...

Can‘t the wallet editor window be integrated into a kio slave and accessed via dolphin? Since it mimics a folder view (which in my eyes is unneccessary, a dialog would be sufficient) it would reduce amount of extra-stuff. A kio slave like wallets:/ would be nice instead of an extra program. And double clicking on a wallet either opens a dialog or maybe opens a “sub-directory” which shows the stored passwords in a way the kwallet manager did.

Albert Astals Cid said...

@Kai: It could, but it would be probably suboptimal for things like maps (e.g. i don't see a way of implementing the show/hide values feature)

But let me repeat i'm not the maintainer of kwalletmanager and all my development plan was removing Qt3Support from it.

Stefan said...

@Chani, tsdgeos: Actually, I also checked out the kwalletmanager code and looked if I could do something about the UI, but I did not arrive at a coherent navigation scheme.

Bille said...

Lovely to see you taking care of the boring but worthwhile jobs!