Saturday, February 09, 2013

Process your reviewboards!

Our "All Review Requests" page in https://git.reviewboard.kde.org has 13 pages of reviews, when sorting by "Last Updated" you'll see that from page 1-6 are reviews that have been updated in the last month, 7-8 in the last two months, 9-12 in the last year and 13 in more than one year.

That's a *lot* of reviews that either where not reviewed at all or where not followed up.

Please, people, pay attention to reviews, if stuff needs to be improved (either if you are the submitter or the reviewer) do speak in a timely manner so we can get stuff commited as nicely as possible.

Let's make the world nicer and review other people's code when they ask for it :-)

Otherwise i'll start closing review requests as discarded because what's the point of having stuff there rot that probably doesn't even apply anymore? ;-)

5 comments:

robby said...

Thanks for bringing attention to this, Albert and thanks for following up on the Tellico items!

Boudewijn Rempt said...

Just don't do that for Calligra. We manage our own review requests.

IAnjo said...

As one of the people who has a patch sitting there ignored, I have to say it did not warm me up to using reviewboard again.

Anonymous said...

As an Amarok user I hope many of the patches are integrated soon. Thanks for bringing it to the attention of the devs.

Albert Astals Cid said...

Don't worry Boud, I'm not going to tell you guys you have 5 review requests that have been sitting there without any activity for 3 months or more.