tag:blogger.com,1999:blog-7523589.post1551152646690217691..comments2024-02-20T19:17:55.835+01:00Comments on TSDgeos' blog: Commit your approved Review Requests!Albert Astals Cidhttp://www.blogger.com/profile/12001470108926138921noreply@blogger.comBlogger5125tag:blogger.com,1999:blog-7523589.post-10925693810260378612014-07-30T04:33:44.534+02:002014-07-30T04:33:44.534+02:00Ahem, sorry, I haven't figured out it's an...Ahem, sorry, I haven't figured out it's an available option. I started googling around what to do after getting "Ship it!" and saw your blog post. Sorry for the inconvenience again and thank you for helping with getting the patch committed.d1vanovhttps://www.blogger.com/profile/08323191102523784932noreply@blogger.comtag:blogger.com,1999:blog-7523589.post-77604624494686374092014-07-29T22:49:33.088+02:002014-07-29T22:49:33.088+02:00You got a ship it 3 hours ago and you come here to...You got a ship it 3 hours ago and you come here to ask me to commit it? Why aren't you asking in the commit review itself?Albert Astals Cidhttps://www.blogger.com/profile/12001470108926138921noreply@blogger.comtag:blogger.com,1999:blog-7523589.post-16781385905789559332014-07-29T19:27:07.937+02:002014-07-29T19:27:07.937+02:00Hi! I've just got one "Ship it!" for...Hi! I've just got one "Ship it!" for my review request: https://git.reviewboard.kde.org/r/114910. I don't have commit rights, could you please commit this patch to latest-the-greatest KDE 4.x branch?d1vanovhttps://www.blogger.com/profile/08323191102523784932noreply@blogger.comtag:blogger.com,1999:blog-7523589.post-78536574683027172032014-05-06T19:50:16.146+02:002014-05-06T19:50:16.146+02:00This message is both for the reviewer and the subm...This message is both for the reviewer and the submitter, everyone should make sure the effort is not wasted.<br /><br />Sure an auto committing magic is nice, are you willing to implement it and make sure it works with our workflow?Albert Astals Cidhttps://www.blogger.com/profile/12001470108926138921noreply@blogger.comtag:blogger.com,1999:blog-7523589.post-17530414135023729522014-05-06T09:57:46.718+02:002014-05-06T09:57:46.718+02:00It has been some time i last submitted any kde pat...It has been some time i last submitted any kde patches, but from what i remember back then the main problme is:<br /><br />Many of those reviewed patches come from people outside kde, that might not even have a way to commit the patches, or are unsure about commiting them even if they got approved.<br /><br />What is needed is somebody in charge of getting approved review requests into kde, either directly through the dev that submitted it, or by committing them himself. There is really no other way to do it.Beat Wolfhttps://www.blogger.com/profile/18328888630877575397noreply@blogger.com