Thursday, February 06, 2020

New help porting to Go >= 1.12

At KDE we have a GitHub mirror. One of the problems about having a mirror is that people routinely try to propose Pull Requests over there, but no one is watching, so they would go stale, which is not good for anyone.

What no one? Actually no, we have kdeclose, a bot that will go over all Pull Requests and gracefully close them suggesting people to move the patch over to KDE infrastructure where we are watching.

The problem is that I'm running that code on Google AppEngine and they are cutting support for the old Go version that it's using, so I would need someone help me port the code to a newer Go version.

Anyone can help me?

P.S: No, I'm not the original author of the code, it's a fork of something else, but that has not been updated either.

Update: This is now done, thanks to Daniele (see first comment). Mega fast, thanks community!

6 comments:

Daniele Tricoli said...

Hello, my go-fu is a bit rusted but I would like to help. Following here[¹] I run the suggested tool `aefix` that changed the imports and fixed some types.

You can find the changes here:
https://github.com/eriol/nopullrequests/commit/02dfe5da7ebe4175ca0e1d80d29d153d515a6c52

From [²] it seems that it's not enough to just run the tool above, but my problem here is that I never used Google App Engine: do you know if they provide a free tier where I can make tests?

HTH,
Daniele

[¹] https://github.com/golang/appengine#updating-from-legacy-import-appengine-packages
[²] https://github.com/golang/appengine#2-update-code-using-deprecated-removed-or-modified-apis

Albert Astals Cid said...

Yes, there's totally a free tier, it's what i'm using :)

Albert Astals Cid said...

Daniele that was it, it compiles now :)

Nick said...

Why not just disable pull requests?

Albert Astals Cid said...

Because unless something has changed recently, you can't

Nick said...

Oops sorry I was thinking of issues. Guess we need to vote on https://github.com/isaacs/github/issues/1191