Showing posts with label reviewboard. Show all posts
Showing posts with label reviewboard. Show all posts

Tuesday, May 06, 2014

Commit your approved Review Requests!

By looking at KDE git Review Board I realize we have over 4 pages of "ship it"-ed review requests that are still marked as not commited.

This is nuts!

I know some of them are still work in progress (yes, it sucks that reviewboard does not let you "unship it" when you find something wrong or when some newbie mistakenly gives himself a +1) but I am pretty sure at least 3 of those 4 pages are stuff that was coded, reviewed, approved and then no one committed it :/

So please go through your reviewboard changes and commit them, or ping the maintainer of the app if you don't have commit rights (and if the maintainer is unresponsive for some reason and it's obvious you had his "Ship it" just come to me and I'll commit it for you).

Saturday, February 09, 2013

Process your reviewboards!

Our "All Review Requests" page in https://git.reviewboard.kde.org has 13 pages of reviews, when sorting by "Last Updated" you'll see that from page 1-6 are reviews that have been updated in the last month, 7-8 in the last two months, 9-12 in the last year and 13 in more than one year.

That's a *lot* of reviews that either where not reviewed at all or where not followed up.

Please, people, pay attention to reviews, if stuff needs to be improved (either if you are the submitter or the reviewer) do speak in a timely manner so we can get stuff commited as nicely as possible.

Let's make the world nicer and review other people's code when they ask for it :-)

Otherwise i'll start closing review requests as discarded because what's the point of having stuff there rot that probably doesn't even apply anymore? ;-)