Tuesday, May 06, 2014

Commit your approved Review Requests!

By looking at KDE git Review Board I realize we have over 4 pages of "ship it"-ed review requests that are still marked as not commited.

This is nuts!

I know some of them are still work in progress (yes, it sucks that reviewboard does not let you "unship it" when you find something wrong or when some newbie mistakenly gives himself a +1) but I am pretty sure at least 3 of those 4 pages are stuff that was coded, reviewed, approved and then no one committed it :/

So please go through your reviewboard changes and commit them, or ping the maintainer of the app if you don't have commit rights (and if the maintainer is unresponsive for some reason and it's obvious you had his "Ship it" just come to me and I'll commit it for you).


Beat Wolf said...

It has been some time i last submitted any kde patches, but from what i remember back then the main problme is:

Many of those reviewed patches come from people outside kde, that might not even have a way to commit the patches, or are unsure about commiting them even if they got approved.

What is needed is somebody in charge of getting approved review requests into kde, either directly through the dev that submitted it, or by committing them himself. There is really no other way to do it.

Albert Astals Cid said...

This message is both for the reviewer and the submitter, everyone should make sure the effort is not wasted.

Sure an auto committing magic is nice, are you willing to implement it and make sure it works with our workflow?

d1vanov said...

Hi! I've just got one "Ship it!" for my review request: https://git.reviewboard.kde.org/r/114910. I don't have commit rights, could you please commit this patch to latest-the-greatest KDE 4.x branch?

Albert Astals Cid said...

You got a ship it 3 hours ago and you come here to ask me to commit it? Why aren't you asking in the commit review itself?

d1vanov said...

Ahem, sorry, I haven't figured out it's an available option. I started googling around what to do after getting "Ship it!" and saw your blog post. Sorry for the inconvenience again and thank you for helping with getting the patch committed.